BUG: Fix infer_dtype result for float with embedded pd.NA #61624
Conversation
| @@ -1086,10 +1086,7 @@ def convert_dtypes( | |||
| elif ( | |||
| infer_objects | |||
| and input_array.dtype == object | |||
| and ( | |||
| isinstance(inferred_dtype, str) | |||
There was a problem hiding this comment.
To be sure, this removal is unrelated to the other change here, is that right? That is, we can remove this line on main and it won't break any tests.
There was a problem hiding this comment.
That's right. I tested it on my personal repo, and all TC passed. (heoh#7)
At the time of writing the commit, I simply judged it as unnecessary code and removed it.
However, after seeing your question, I took a second look at the convert_dtypes() function. It exists for the integer and boolean cases as well, and I felt that it was intended to explicitly indicate that the inferred_dtype is of type str.
(Previous work: #50094 a4c409e)
Even though the test passes without it, I don't understand pandas well enough yet to anticipate the side effects. For now, I think it's safer to respect the existing code style, so I added it back.(ddd7e3b)
Please feel free to let me know if I need to make any corrections again. Thanks for the review.
rhshadrach
added
Bug
Missing-data
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.Description
Fix a bug in :func:
api.types.infer_dtypereturning "mixed-integer-float" for float andpd.NAmix.Cause
This problem occurred because the existing
is_float_arrayinternally fixedskipna=False. It was solved by adding theskipnaargument.